tsukimi2 519af8f1b6 Fix for search guilds result being inconsistent between "My Guilds" and "Discover Guilds" (#11903)
* Fix bug to allow guild summary and description to match against search term in MyGuilds component

* Add unit test to groupUtilities to test filterGroup function

* Changes made after running npm:run:lint

* Fix bug when filter guild function does not match against guild size correctly when the guild has member count = 100 or 1000

According to habitica wiki Guilds Guide, gold-tier guilds are guilds with 1000 or more members.  However, under the current code of filter guild function, it matches guilds as gold-tier as strictly more than 1000 members, excluding 1000 members.  Similar silver-tier guilds should have 100 to 999 members, but the current code it matches guilds as silver-tier for members between 101 and 999 members.

* Added unit tests to test the newly added code in the groupsUtilities mixin for the current issue

* Add unit testing to test search guild name, summary, and description in myGuilds component

* Add suggestions from lint

* Added searching by guild summary and white space handling in search terms.

For discover guilds component, added the following:
1) handling of searching by guild summary
2) preventing white space in search terms to display all guilds
3) added test cases for testing the search functionality in discove guilds to ensure consistent behaviour between the searching in MyGuilds and public guilds.

* Remove console statements from test file

* Implement suggestions from lint.

Co-authored-by: osiris <eynsan@yahoo.co.uk>
2020-03-16 20:03:48 +01:00
2017-10-12 16:44:28 +02:00
2019-11-01 19:01:15 +01:00
2020-03-13 10:59:52 -05:00
2020-02-28 13:30:41 +00:00
2019-10-02 20:09:26 +02:00
2016-09-07 08:44:57 -05:00
2019-10-13 18:35:33 +02:00
2019-10-08 22:57:22 +02:00
2020-01-12 19:34:40 +01:00
2019-08-19 22:43:17 +02:00
2019-10-18 16:52:21 +02:00
2019-10-15 15:32:53 +02:00
2016-06-21 06:42:20 -05:00
2016-05-23 13:58:31 +02:00

Habitica Build Status Code Climate Bountysource Open Source Helpers

Habitica is an open source habit building program which treats your life like a Role Playing Game. Level up as you succeed, lose HP as you fail, earn money to buy weapons and armor.

We need more programmers! Your assistance will be greatly appreciated. The wiki pages below and the additional pages they link to will tell you how to get started on contributing code and where you can go to seek further help or ask questions:

Habitica's code is licensed as described at https://github.com/HabitRPG/habitica/blob/develop/LICENSE

Found a bug? Please report it in the Report a Bug guild rather than creating an issue (an admin will advise you if a new issue is necessary; usually it is not).

Have any questions about Habitica or its community? See the links in the habitica.com website's Help menu or drop in to Guilds > Tavern Chat to ask questions or chat socially!

S
Description
A habit tracker app which treats your goals like a Role Playing Game.
Readme 1.9 GiB
Languages
JavaScript 51.7%
Vue 23.8%
CSS 23.7%
SCSS 0.7%