improve improvement category validation

2016-03-04 14:00:26 +01:00
parent 668ad6ff45
commit a1e1ac211f
1 changed files with 6 additions and 8 deletions
@@ -391,14 +391,12 @@ var UserSchema = new Schema({
      raisePet: {type: Boolean, 'default': false},
      streak: {type: Boolean, 'default': false}
    },
-    improvementCategories: {type: Array, validate: function (categories) {
-      var validValues = true;
-      categories.forEach(function (cat) {
-        if (['work', 'exercise', 'healthWellness', 'school', 'teams', 'chores', 'creativity'].indexOf(cat) === -1){
-          validValues = false;
-        }
-      });
-      return validValues;
+    improvementCategories: {
+      type: Array,
+      validate: (categories) => {
+        const validCategories = ['work', 'exercise', 'healthWellness', 'school', 'teams', 'chores', 'creativity'];
+        let isValidCategory = categories.every(category => validValues.indexOf(category) !== -1);
+        return isValidCategory;
    }}
  },
  profile: {