remove advancedCollapsed settings to start it opened

test/common/ops/addTask.js

@@ -126,13 +126,5 @@ describe('shared.ops.addTask', () => {
       expect(addTask(user)._editing).not.be.ok;
       expect(addTask(user)._edit).to.not.be.ok;
     });
-
-    it('respects advancedCollapsed preference', () => {
-      user.preferences.advancedCollapsed = true;
-      expect(addTask(user)._advanced).not.be.ok;
-
-      user.preferences.advancedCollapsed = false;
-      expect(addTask(user)._advanced).to.be.ok;
-    });
   });
 });

website/client/src/components/tasks/taskModal.vue

@@ -1183,7 +1183,6 @@ export default {
     },
   },
   async mounted () {
-    this.showAdvancedOptions = !this.user.preferences.advancedCollapsed;
     if (this.groupId) {
       const groupResponse = await axios.get(`/api/v4/groups/${this.groupId}`);
       this.managers = Object.keys(groupResponse.data.data.managers);

website/client/src/pages/settings/settingRows/taskSettings.vue

@@ -1,21 +1,5 @@
 <template>
   <fragment>
-    <tr>
-      <td class="settings-label">
-        <span
-          v-b-popover.hover.right="$t('startAdvCollapsedPop')"
-          class="hint"
-        >{{ $t('startAdvCollapsed') }}</span>
-      </td>
-      <td class="settings-value">
-      </td>
-      <td class="settings-button">
-        <toggle-switch
-          v-model="user.preferences.advancedCollapsed"
-          @change="setUserPreference('advancedCollapsed')"
-        />
-      </td>
-    </tr>
     <tr>
       <td class="settings-label">
         <span

website/common/locales/en/settings.json

@@ -16,8 +16,6 @@
     "dailyDueDefaultView": "Set Dailies default to 'due' tab",
     "dailyDueDefaultViewPop": "With this option set, the Dailies tasks will default to 'due' instead of 'all'",
     "reverseChatOrder": "Show chat messages in reverse order",
-    "startAdvCollapsed": "Advanced Settings in tasks start collapsed",
-    "startAdvCollapsedPop": "With this option set, Advanced Settings will be hidden when you first open a task for editing.",
     "dontShowAgain": "Don't show this again",
     "showLevelUpModal": "When Gaining a Level",
     "showHatchPetModal": "When Hatching a Pet",

website/common/script/ops/addTask.js

@@ -12,7 +12,6 @@ export default function addTask (user, req = { body: {} }) {
   if (task._editing) {
     task._edit = clone(task);
   }
-  task._advanced = !user.preferences.advancedCollapsed;
 
   return task;
 }